-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP4: Add container_security_operator_exists to PCIDSS profile #11776
OCP4: Add container_security_operator_exists to PCIDSS profile #11776
Conversation
f2f2ec1
to
6830045
Compare
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
6830045
to
375d50b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule seems to align closer to 6.3.2
.
It is not clear to me how the rule container_security_operator_exists
supports requirements 8.6.1
, 8.6.2
and 8.6.3
.
applications/openshift/risk-assessment/container_security_operator_exists/rule.yml
Outdated
Show resolved
Hide resolved
375d50b
to
c6af183
Compare
@Vincent056 You got into a conflict with another PR of yours: |
c6af183
to
593f865
Compare
@yuumasato wondering if you have seen |
@Vincent056 Yes, It means that Line 8 in 593f865
So you don't need to add the reference in the rule. |
This pr adds container_security_operator_exists rule to PCI-DSS 4.0 6.3.2
593f865
to
6dcc5bc
Compare
Code Climate has analyzed commit 6dcc5bc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.2% (0.0% change). View more on Code Climate. |
Merging. |
This pr adds
container_security_operator_exists
rule to PCI-DSS 4.0 6.3.2