Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use failed_when:false for Ansible register: checks #11782

Merged
merged 1 commit into from
Apr 3, 2024
Merged

use failed_when:false for Ansible register: checks #11782

merged 1 commit into from
Apr 3, 2024

Commits on Apr 2, 2024

  1. use failed_when:false for Ansible register: checks 

    Using ignore_errors leads to user-visible fatal errors
produced by ansible-playbook:

  TASK [Enable FIPS Mode - Check to See the Current Status of FIPS Mode] *********
  fatal: [192.168.122.178]: FAILED! => {"changed": false, "cmd": ["/usr/bin/fips-mode-setup", "--check"] ...

These are indistinguishable from actually terminating
fatal errors (to a log-reading script) that need to be
investigated.

Using failed_when avoids those, while still registering
the output for use by other checks, as done by many other
checks:

  $ grep -i 'failed_when: false' -r linux_os/ | wc -l
  25

Signed-off-by: Jiri Jaburek <comps@nomail.dom>
    @comps
    comps committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    40fdde4 View commit details
    Browse the repository at this point in the history