-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try 4110 for file_permissions_sudo #11805
Try 4110 for file_permissions_sudo #11805
Conversation
Skipping CI for Draft Pull Request. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
I think it might be worth modifying anssi.yml control and move the rule from related_rules to rules... and let's see what the tests show. |
d9fc62d
to
dda8c4f
Compare
And everything works? |
hm... I did a thorough investigation of this requirement and I wonder how to solve it. |
a420d1d
to
0edd9c5
Compare
The test scenarios should be updated since the rule no longer accepts stricter permissions: |
742bd78
to
57469c9
Compare
The permissions 4110 need to be exact to ensure that sudo operates correctly.
This is needed for R38.
Before this test would always fail this commit adds some conditionals to check if ALLOW_STRICTER_PERMISSIONS is true and adjust the tests if the value is true.
57469c9
to
f8eabb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor point, to remove an outdated note.
Since the status is now automated
Code Climate has analyzed commit 7c2780a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description:
Try 4110 for file_permissions_sudo.
Rationale:
Better align with the benchmark.