-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Rsyslog Rainer regex to find log files #11808
Improve Rsyslog Rainer regex to find log files #11808
Conversation
There are other entries in RainerScript syntax used to specify filepaths, but the files are not used for logs. This test scenario ensure these lines are present so we can properly test assessment and remediation.
Minor improvement in Bash and Ansible to avoid matching undesired entries. OVAL regex was also improved in alignment to remediation.
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit d535042 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much.
Description:
There are other entries in RainerScript syntax used to specify filepaths, but the files are not used for logs.
It was included a test scenario to test these exceptions.
The regex was also improved in OVAL, Bash and Ansible.
Rationale:
Review Hints: