-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the requires
to sshd_set_keepalive
on sshd_set_idle_timeout
#11815
Conversation
The Ubuntu fix should be for everyone.
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
/packit rebuild-failed |
/packit build |
The rule |
This is no longer true in the STIG. While it is true that 8.5+ changes the behavior there is value in this rule in RHEL 8.5+.
I just removed the restriction. The STIG doesn't have this and there still value in this rule for RHEL 8.5+. |
Code Climate has analyzed commit 92bd690 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.2% (0.0% change). View more on Code Climate. |
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The rule sshd_set_idle_timeout used to require rule sshd_set_keepalive_0 for Red Hat linuxes. But after ComplianceAsCode#11815 it started to require rules sshd_set_keepalive. This selects the rule that satifyes the requirement.
The rule sshd_set_idle_timeout used to require rule sshd_set_keepalive_0 for Red Hat linuxes. But after ComplianceAsCode#11815 it started to require rules sshd_set_keepalive. This selects the rule that satifyes the requirement.
The rule sshd_set_idle_timeout used to require rule sshd_set_keepalive_0 for Red Hat linuxes. But after ComplianceAsCode#11815 it started to require rules sshd_set_keepalive. This selects the rule that satifyes the requirement.
Description:
Clean up the
requires
for sshd_set_keepalive.Rationale:
Fixes #11803