-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ol8 stig #11828
Update ol8 stig #11828
Conversation
Remove rule account_emergency_expire_date since account_temp_expire_date already covers the same requirement Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Replace audit_immutable_login_uids rule with audit_rules_immutable_login_uids. This other rule is better aligned with requirement Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Replace ssh_private_keys_have_passcode rule with ssh_keys_passphrase_protected, both rules are manual, but the new one includes the 'policy' directory Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
STIG OL08-00-030062 allows 'hostname', 'fqd', or 'numeric' as the stig selector for this variable Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Hi @Xeicker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 65b9629 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Overriding CODEOWNERs as there are no Oracle maintainers.
Waving the Automatus tests for SLE15 as they failing due since that rule isn't selected on that platform.
Description:
account_emergency_expire_date
sinceaccount_temp_expire_date
already covers the same requirementaudit_immutable_login_uids
rule withaudit_rules_immutable_login_uids
. This other rule is better aligned with requirementOL08-00-030122
sshd_set_keepalive_0
withsshd_set_keepalive
to better cover requirementOL08-00-010200
ssh_private_keys_have_passcode
rule withssh_keys_passphrase_protected
, both rules are manual, but the new one includes the 'policy' directoryenable_authselect
to ol8 stig (This helps rules related to authselect)var_auditd_name_format
. STIG OL08-00-030062 allows 'hostname', 'fqd', or 'numeric' as the stig selector for this variableauditd_name_format
. Cover some extra scenarios and set explicitly thevar_auditd_name_format
variableRationale:
Review Hints:
auditd_name_format
need more careful check.Note: the rule
ssh_private_keys_have_passcode
is no longer in use, let me know if it is reasonable to delete it, as it is basically the same asssh_keys_passphrase_protected