Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ol8 profiles #11829

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Apr 16, 2024

Description:

  • Add kernel configuration rules to anssi profile
  • Add enable_authselect to e8
  • Remove var_accounts_password_minlen_login_defs definition in cjis profile to use default
  • Remove rule sshd_use_priv_separation from hipaa profile, as it looks for a deprecated config in sshd_config

Rationale:

  • Update ol8 profiles with latest changes in upstream

Review Hints:

  • No new functionality, only add/remove rules from ol8 profiles

better to document expected failures than don't give any result

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
This profile doesn't include the rule that uses this variable

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
This option was deprecated in openssh

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested a review from a team as a code owner April 16, 2024 21:51
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 16, 2024
Copy link

openshift-ci bot commented Apr 16, 2024

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added the Oracle Linux Oracle Linux product related. label Apr 16, 2024
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11829
This image was built from commit: 9b29a3e

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11829

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11829 make deploy-local

Copy link

codeclimate bot commented Apr 16, 2024

Code Climate has analyzed commit 9b29a3e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Apr 17, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Apr 17, 2024
@marcusburghardt
Copy link
Member

Overriding CODEOWNERS since a Oracle approver is not currently available.
@Xeicker is a Oracle Linux maintainer. We only have to finish some formalities of #10176

@marcusburghardt marcusburghardt merged commit d3fef69 into ComplianceAsCode:master Apr 17, 2024
40 checks passed
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants