Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken exception message #11842

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jan-cerny
Copy link
Collaborator

Fixing None shown in the following message:

ValueError: The rule 'package_ntp_removed' isn't mapped to any component! Insert the rule ID to at least one file in 'None'.

Review Hints:

Remove a rule from a component file in the /components directory, then build content

Fixing `None` shown in the following message:
ValueError: The rule 'package_ntp_removed' isn't mapped to any component!
Insert the rule ID to at least one file in 'None'.
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11842
This image was built from commit: 9dbed12

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11842

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11842 make deploy-local

Copy link

codeclimate bot commented Apr 17, 2024

Code Climate has analyzed commit 9dbed12 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the Infrastructure Our content build system label Apr 17, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Apr 17, 2024
@marcusburghardt marcusburghardt self-assigned this Apr 17, 2024
@marcusburghardt
Copy link
Member

Much better. E.g.:
ValueError: The rule 'audit_access_failed' isn't mapped to any component! Insert the rule ID to at least one file in '/.../content/components'.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks

@marcusburghardt marcusburghardt merged commit 4c52033 into ComplianceAsCode:master Apr 17, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants