-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content_diff when a rule is removed #11855
Fix content_diff when a rule is removed #11855
Conversation
50dfc57
to
663d5fe
Compare
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently when the function was split in this pull request: https://github.com/ComplianceAsCode/content/pull/9634/files
The missing_rules declaration was left out.
But checking more thoroughly, this variable (missing_rules) doesn't seem to be used anywhere in this file, look for other occurrences in different functions.
I believe we can remove from everywhere in this file.
@Mab879 it would be better to add into description that it affects the DISA content comparison only |
I can add something to the description about that. |
dc2e908
to
e6d3120
Compare
e6d3120
to
41bc802
Compare
Code Climate has analyzed commit 41bc802 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.2% (0.0% change). View more on Code Climate. |
/packit build |
Description:
Fix content_diff when a rule is removed the code doesn't crash.
This only happened for DISA content.
Rationale:
So the script runs when a rule is removed.