Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out TMT plans to separate Packit jobs #11860

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

comps
Copy link
Collaborator

@comps comps commented Apr 19, 2024

Description:

This is another attempt at #11807 with only the .packit.yaml split, as other changes were done in #11809 already.

The separate Packit jobs should be easy to re-run via /packit rerun-failed, avoiding the re-running of already-passed tests, which are the typical sources of (random) failures now.

This also removes unused merge queue code for tests, as leaving it in place would lead to a lot more copy/pasted .packit.yaml code.

Review Hints:

  • Note that, prior to merging this, "required checks" for this project will need to be adjusted to include these individual jobs (via a wildcard, or manually -- wildcarding is possible for GH Actions, but I'm not sure about Packit CI actions).

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 19, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11860
This image was built from commit: c8e2f84

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11860

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11860 make deploy-local

Also remove unused merge queue code for tests, as leaving it
in place would lead to a lot more copy/pasted .packit.yaml code.

Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Using just the name is likely less confusing, since it maps
directly to Contest test names.

Also, it minimizes the .fmf file noise.

Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Apr 22, 2024
It seems the profile is not quite ready for Testing Farm.

Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Copy link

codeclimate bot commented Apr 22, 2024

Code Climate has analyzed commit c8e2f84 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@comps
Copy link
Collaborator Author

comps commented Apr 23, 2024

This is ready to be reviewed / merged, someone just needs to remove the

testing-farm:centos-7-x86_64 Expected — Waiting for status to be reported
testing-farm:centos-stream-8-x86_64 Expected — Waiting for status to be reported
testing-farm:centos-stream-9-x86_64 Expected — Waiting for status to be reported

from required checks, and add the new jobs as required.

@jan-cerny
Copy link
Collaborator

I'm not able to set the new jobs as required. I will try if it becomes possible to set them as required after merging the PR.

@jan-cerny jan-cerny merged commit 5738d71 into ComplianceAsCode:master Apr 24, 2024
113 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants