Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dirs in sysctl template for Ubuntu 20.04/22.04 #11862

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 20, 2024

Description:

  • Modified sysctl template to treat /lib/sysctl.d as a package-managed directory on Ubuntu.

Rationale:

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 20, 2024
Copy link

openshift-ci bot commented Apr 20, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 20, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11862
This image was built from commit: acc14f7

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11862

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11862 make deploy-local

@marcusburghardt marcusburghardt added the Ubuntu Ubuntu product related. label Apr 22, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Apr 22, 2024
@dodys dodys self-assigned this Apr 26, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 26, 2024
On Ubuntu /lib is symlinked to /usr/lib, thus /lib/sysctl.d
contains package-managed configs, which should not be
modified and can be incorrect if overriden elsewhere (see ComplianceAsCode#10637).
Copy link

codeclimate bot commented Apr 29, 2024

Code Climate has analyzed commit acc14f7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented Apr 29, 2024

/packit test

1 similar comment
@dodys
Copy link
Contributor

dodys commented Apr 29, 2024

/packit test

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

@vojtapolasek vojtapolasek modified the milestones: 0.1.73, 0.1.74 Apr 30, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

@dodys dodys merged commit a69b48e into ComplianceAsCode:master Apr 30, 2024
113 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants