-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dirs in sysctl template for Ubuntu 20.04/22.04 #11862
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
86213d8
to
627eeec
Compare
On Ubuntu /lib is symlinked to /usr/lib, thus /lib/sysctl.d contains package-managed configs, which should not be modified and can be incorrect if overriden elsewhere (see ComplianceAsCode#10637).
627eeec
to
acc14f7
Compare
Code Climate has analyzed commit acc14f7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/packit test |
1 similar comment
/packit test |
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/packit build |
Description:
/lib/sysctl.d
as a package-managed directory on Ubuntu.Rationale:
/lib
is symlinked to/usr/lib
, thus/lib/sysctl.d
contains package-managed configs, which should not be modified and can be incorrect if overridden elsewhere (/run
,/usr/local
,/etc
). See Update sysctl template to check(and not fix) /usr/lib/sysctl.d directory #10637