Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ol8 pcidss #11867

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Update ol8 pcidss #11867

merged 2 commits into from
Apr 26, 2024

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Apr 22, 2024

Description:

  • Align OL8 pci-dss with latest available controls in project
  • Add OL8 to installed_OS_is_FIPS_certified oval list

Rationale:

  • Update OL8 pci-dss requirements

@Xeicker Xeicker requested a review from a team as a code owner April 22, 2024 19:58
Copy link

openshift-ci bot commented Apr 22, 2024

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 22, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_installed_OS_is_FIPS_certified' differs.
--- oval:ssg-installed_OS_is_FIPS_certified:def:1
+++ oval:ssg-installed_OS_is_FIPS_certified:def:1
@@ -3,6 +3,7 @@
 extend_definition oval:ssg-installed_OS_is_rhel8:def:1
 extend_definition oval:ssg-installed_OS_is_rhcos4:def:1
 extend_definition oval:ssg-installed_OS_is_ol7:def:1
+extend_definition oval:ssg-installed_OS_is_ol8:def:1
 extend_definition oval:ssg-installed_OS_is_sle12:def:1
 extend_definition oval:ssg-installed_OS_is_sle15:def:1
 extend_definition oval:ssg-installed_OS_is_ubuntu1604:def:1

Copy link

github-actions bot commented Apr 22, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11867
This image was built from commit: 367977a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11867

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11867 make deploy-local

@Xeicker Xeicker added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. pci-dss labels Apr 24, 2024
@Mab879
Copy link
Member

Mab879 commented Apr 26, 2024

Please rebase this PR on latest master, that should fix the testing farm issues.

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Copy link

codeclimate bot commented Apr 26, 2024

Code Climate has analyzed commit 367977a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.73 milestone Apr 26, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Overriding CODEOWNERS since @Xeicker cannot approve his own PRs.

@Mab879 Mab879 merged commit cfae93b into ComplianceAsCode:master Apr 26, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. pci-dss Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants