Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial RHEL 10 PCI DSS profile #11872

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Apr 23, 2024

Description:

Add initial RHEL 10 PCI DSS profile

Rationale:

RHEL 10

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 23, 2024
Copy link

openshift-ci bot commented Apr 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 23, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11872
This image was built from commit: 931603b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11872

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11872 make deploy-local

@Mab879 Mab879 marked this pull request as ready for review April 24, 2024 13:01
@Mab879 Mab879 requested a review from a team as a code owner April 24, 2024 13:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 24, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 24, 2024
@Mab879 Mab879 added New Profile Issues or pull requests related to new Profiles. pci-dss RHEL10 Red Hat Enterprise Linux 10 product related. labels Apr 24, 2024
@marcusburghardt marcusburghardt self-assigned this Apr 26, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor points.

products/rhel10/profiles/pcidss.profile Outdated Show resolved Hide resolved
products/rhel10/profiles/pcidss.profile Outdated Show resolved Hide resolved
Co-authored-by: Marcus Burghardt <2074099+marcusburghardt@users.noreply.github.com>
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

codeclimate bot commented Apr 26, 2024

Code Climate has analyzed commit 931603b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.1% change).

View more on Code Climate.

@marcusburghardt marcusburghardt merged commit 771c937 into ComplianceAsCode:master Apr 26, 2024
113 checks passed
@Mab879 Mab879 deleted the init_rhel10_pcidss branch April 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Profile Issues or pull requests related to new Profiles. pci-dss RHEL10 Red Hat Enterprise Linux 10 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants