Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align chronyd_sync_clock to Ubuntu 22.04 STIG #11883

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 24, 2024

Description:

Switch to using makestep 1 1 in Ubuntu 2204 to align with STIG rule UBTU-22-252015

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 24, 2024
Copy link

openshift-ci bot commented Apr 24, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OCIL for rule 'xccdf_org.ssgproject.content_rule_chronyd_sync_clock' differs.
--- ocil:ssg-chronyd_sync_clock_ocil:questionnaire:1
+++ ocil:ssg-chronyd_sync_clock_ocil:questionnaire:1
@@ -4,7 +4,7 @@
 $ sudo grep makestep /etc/chrony/chrony.conf
 makestep 1 -1
 
-If it is not set to "1 -1", edit the /etc/chrony/chrony.conf file
+If it is not set to the above value, edit the /etc/chrony/chrony.conf file
 and add:
 makestep 1 -1
 Restart the chrony service:

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11883
This image was built from commit: e080007

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11883

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11883 make deploy-local

Copy link

codeclimate bot commented Apr 24, 2024

Code Climate has analyzed commit e080007 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Apr 25, 2024
@dodys dodys self-assigned this Apr 26, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 26, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 8ec83e8 into ComplianceAsCode:master Apr 26, 2024
109 of 113 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 26, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants