Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase coverage RHEL-08-010770 and RHEL-07-020710 #11892

Merged

Conversation

vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Apr 25, 2024

Description:

  • modify RHEL 8 STIG profile and use the file_permission_user_init_files_root rule instead of file_permission_user_init_files
  • also add appropriate variable so that all dot files are examined during the scan

Rationale:

Review Hints:

build rhel8 products and examine stig and stig_gui profiles

@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Apr 25, 2024
@vojtapolasek vojtapolasek added this to the 0.1.73 milestone Apr 25, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner April 25, 2024 14:50
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 25, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11892
This image was built from commit: 5897559

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11892

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11892 make deploy-local

@Mab879 Mab879 self-assigned this Apr 25, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing farm failures look valid.

@vojtapolasek
Copy link
Collaborator Author

/packit retest-failed

@vojtapolasek vojtapolasek force-pushed the rhel8_stig_extend_user_init_files branch from fa7cdef to 8a086cf Compare April 26, 2024 13:01
@vojtapolasek vojtapolasek modified the milestones: 0.1.73, 0.1.74 Apr 30, 2024
@Mab879
Copy link
Member

Mab879 commented Jun 10, 2024

@vojtapolasek what are the next steps on this?

I believe that my existing comments are still valid.

@vojtapolasek vojtapolasek force-pushed the rhel8_stig_extend_user_init_files branch from 8a086cf to 5897559 Compare June 20, 2024 15:00
@vojtapolasek
Copy link
Collaborator Author

@Mab879 since rhel7 product is no longer in this repo, I modified the PR to include only rhel8 related changes.

Copy link

codeclimate bot commented Jun 20, 2024

Code Climate has analyzed commit 5897559 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the PR.

@Mab879 Mab879 merged commit 9fb1f47 into ComplianceAsCode:master Jun 21, 2024
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants