Fix #11895 issue

[marcofortina]

Description:

This PR fixes wrong check on /sbin/audispd on Debian >= 11 and Ubuntu >= 22.04.

Rationale:

• Fixes Rule "Configure AIDE to Verify the Audit Tools" fails on Ubuntu 22.04 #11895

Review Hints:

Build the product:

./build_product ubuntu2204

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2204-playbook-cis_level1_server.yml --tags "aide_check_audit_tools"

To test changes with bash, run the remediation sections: xccdf_org.ssgproject.content_rule_aide_check_audit_tools

Expected output:

Title   Configure AIDE to Verify the Audit Tools
Rule    xccdf_org.ssgproject.content_rule_aide_check_audit_tools
Result  pass

[openshift-ci]

Hi @marcofortina. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[github-actions]

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11897
This image was built from commit: e489309

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11897

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11897 make deploy-local

[dodys]

Please fix the description, aide_build_database has nothing to do with audisp

[dodys]

/packit retest-failed

[marcofortina]

Please fix the description, aide_build_database has nothing to do with audisp

I think I already fixed the description. Am I wrong?

[dodys]

lgtm, thanks!

[dodys]

just a small improvement

[codeclimate]

Code Climate has analyzed commit e489309 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

[dodys]

lgtm, thanks!

[mpurg]

Looks like there is a difference between CIS and STIG with respect to this variable.
According to Ubuntu 22.04 STIG, rule UBTU-22-651030, aide should also check the integrity of audispd.

I suggest we re-set the var to yes, enabling the check for all benchmarks, and thus introducing an (negligible) extra check in CIS, instead of having a missing check in STIG.

[dodys]

@mpurg audispd doesn't exist on 22.04. DISA needs to update their benchmark.

[mpurg]

Ooops, mybad, should've read the original issue 🤦
All good then, I'll inform DISA.