Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to Create a Control file from references #11916

Merged
merged 6 commits into from
May 2, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Apr 29, 2024

Description:

This PR adds a script create a skeleton control from a given reference,

Rationale:

Help with creating control files for RHEL 10.

Review Hints:

Follow the example in the docs.

@Mab879 Mab879 added the Documentation Update in project documentation. label Apr 29, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 29, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 29, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11916
This image was built from commit: dd3338f

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11916

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11916 make deploy-local

@jan-cerny jan-cerny self-assigned this Apr 30, 2024
@vojtapolasek vojtapolasek modified the milestones: 0.1.73, 0.1.74 Apr 30, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to used the script for ospp and hipaa, it worked fine and the output file looks sane. This is very useful.

I have only small problems.

docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
utils/build_control_from_reference.py Outdated Show resolved Hide resolved
utils/build_control_from_reference.py Outdated Show resolved Hide resolved
utils/build_control_from_reference.py Outdated Show resolved Hide resolved
utils/build_control_from_reference.py Outdated Show resolved Hide resolved
utils/build_control_from_reference.py Outdated Show resolved Hide resolved
utils/build_control_from_reference.py Outdated Show resolved Hide resolved
Mab879 added a commit to Mab879/content that referenced this pull request Apr 30, 2024
Copy link

codeclimate bot commented May 1, 2024

Code Climate has analyzed commit dd3338f and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the build_control_from_reference, checked the output and I have run the new CTest test.

@jan-cerny jan-cerny merged commit 9328ed1 into ComplianceAsCode:master May 2, 2024
112 of 113 checks passed
@Mab879 Mab879 deleted the add_ref_to_control_script branch May 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants