Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when loading yaml stream #11962

Merged

Conversation

marcusburghardt
Copy link
Member

Description:

During tests with Ansible macros it was noticed a case where the Ansible task names include "{{{ rule_title }}}" and an specific rule has special symbols in its title.
This was causing the load of the stream to fail but the exception was not clear or easy to debug.
So, it was created an exception for this case giving some hints for the developer.

Rationale:

  • Easier development.

@marcusburghardt marcusburghardt added the Infrastructure Our content build system label May 7, 2024
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11962
This image was built from commit: 47b5c3b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11962

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11962 make deploy-local

During tests with Ansible macros it was noticed a case where the Ansible
task names include "{{{ rule_title }}}" and an specific rule has special
symbols in its title. This was causing the load of the stream to fail
but the exception was not clear or easy to debug. So, it was created an
exception for this case giving some hints for the developer.
Copy link

codeclimate bot commented May 8, 2024

Code Climate has analyzed commit 47b5c3b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 33.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this May 9, 2024
@jan-cerny jan-cerny merged commit a8f8434 into ComplianceAsCode:master May 9, 2024
112 of 113 checks passed
@marcusburghardt marcusburghardt deleted the improve_yaml_processing branch May 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants