Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all boolean values in dnf.conf #11965

Merged
merged 4 commits into from
May 8, 2024

Conversation

marcusburghardt
Copy link
Member

Description:

According to dnf.conf man, "1", "True" and "yes" are accepted values for boolean.

Rationale:

More flexibility for valid values during the assessment.

@marcusburghardt marcusburghardt added the Update Rule Issues or pull requests related to Rules updates. label May 7, 2024
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11965
This image was built from commit: a9d77f3

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11965

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11965 make deploy-local

@Mab879 Mab879 self-assigned this May 7, 2024
Ensure the parameter is also considered and not only its value.
Copy link

codeclimate bot commented May 8, 2024

Code Climate has analyzed commit a9d77f3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatus passes locally.

Thanks for the PR!

@Mab879 Mab879 merged commit fbe8968 into ComplianceAsCode:master May 8, 2024
111 of 113 checks passed
@marcusburghardt marcusburghardt deleted the dnf-conf-values branch May 10, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants