-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stabilization]: add when conditional to Ansible remediation of sssd_enable_pam_services #11979
[Stabilization]: add when conditional to Ansible remediation of sssd_enable_pam_services #11979
Conversation
older Ansible versions might terminate prematurely if there are no config files found in /etc/sssd/conf.d directory
This datastream diff is auto generated by the check Click here to see the full diffansible remediation for rule 'xccdf_org.ssgproject.content_rule_sssd_enable_pam_services' differs.
--- xccdf_org.ssgproject.content_rule_sssd_enable_pam_services
+++ xccdf_org.ssgproject.content_rule_sssd_enable_pam_services
@@ -39,7 +39,9 @@
replace: \1,pam
with_items: '{{ sssd_conf_d_files.files | map(attribute=''path'') }}'
register: modify_lines_sssd_conf_d_files
- when: '"sssd-common" in ansible_facts.packages'
+ when:
+ - '"sssd-common" in ansible_facts.packages'
+ - sssd_conf_d_files.matched is defined and sssd_conf_d_files.matched >= 1
tags:
- CCE-82446-6
- NIST-800-53-CM-6(a) |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed on RHEL 7.9 that this patch fixes the problem.
The fail of Automatus on SLE15 is expected because this rule isn't part of the SLE15 content.
@vojtapolasek please send a link to the master variant of this patch |
354a95c
into
ComplianceAsCode:stabilization-v0.1.73
The PR against master is here: #11982 |
Description:
Rationale:
Review Hints:
If you build the content before this PR, it should crash. It should finish without errors when this PR is added.