-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align sshd_use_approved_ciphers_ordered_stig with Ubuntu STIG #11983
Conversation
Text was aligned with STIG rules UBTU-20-010044 and UBTU-22-255050.
…stig The remediation now uses the bash_sshd_remediation macro and the sshd_approved_ciphers variable.
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
The OVAL now also allows distributed configs and uses the variable `sshd_approved_ciphers` instead of hardcoded values. The implementation is based on the template `sshd_lineinfile`, modified to allow external variables as values and checking for FIPS compliant OS.
…ed_stig The remediation now uses the ansible_sshd_set macro and the sshd_approved_ciphers variable.
b609023
to
0918aac
Compare
Code Climate has analyzed commit 0918aac and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
sshd_use_approved_ciphers_ordered_stig
rule to better align with Ubuntu STIG (UBTU-20-010044, UBTU-22-255050)sshd_approved_ciphers
variableRationale: