Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gating #12041

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Update Gating #12041

merged 7 commits into from
Jun 3, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented May 30, 2024

Description:

Updating gating to ensure that all products are built once.

Rationale:

Preventing things like #12040 and #12033

Review Hints:

Review each commit for details on why the changes where made.

@Mab879 Mab879 added the Infrastructure Our content build system label May 30, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 30, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 30, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12041
This image was built from commit: 6d7abd1

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12041

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12041 make deploy-local

@Mab879
Copy link
Member Author

Mab879 commented May 30, 2024

Depends on #12040

@marcusburghardt marcusburghardt self-assigned this May 31, 2024
To check RHEL 10 as a derivative
This is to reduce the amount of duplication that
is done by gating.
This is to reduce the amount of duplication that
is done by gating.
Ensure that Debian 12 is tested in CI.
Ensure these products are tested in CI.
We should only build every product once.
The products added in this commit where not
tested anywhere else. The goal is to catch issues
before the nightly build.
Copy link

codeclimate bot commented May 31, 2024

Code Climate has analyzed commit 6d7abd1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked how it was organized. Thanks.

@marcusburghardt marcusburghardt merged commit 44dfbf6 into ComplianceAsCode:master Jun 3, 2024
113 checks passed
@Mab879 Mab879 deleted the update_gating branch June 3, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants