Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include product property in profile class #12050

Merged

Conversation

marcusburghardt
Copy link
Member

Description:

All profiles have a product and having this property defined in profile object is very helpful to collect and classify stats from profiles.

Rationale:

Makes it easier to classify stats from profiles.

All profiles have a product and having this property defined in profile
object is very helpful to collect and classify stats from profiles.
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone Jun 6, 2024
@marcusburghardt marcusburghardt added the Infrastructure Our content build system label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 6, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12050
This image was built from commit: f5656d1

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12050

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12050 make deploy-local

Copy link

codeclimate bot commented Jun 6, 2024

Code Climate has analyzed commit f5656d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-cerny jan-cerny self-assigned this Jun 7, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have add a print statement to the ctor and I have executed most-used-rules and most-used-components subcommand.

@marcusburghardt
Copy link
Member Author

This change doesn't affect the failed CI tests with CS8. They can be safely waived.

@jan-cerny
Copy link
Collaborator

The fail of TF on CS 8 isn't caused by this PR but is caused by the CS 8 sunset.

@jan-cerny jan-cerny merged commit 2e85dc8 into ComplianceAsCode:master Jun 7, 2024
87 of 113 checks passed
@marcusburghardt marcusburghardt deleted the profile_class_product branch June 7, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants