-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Automatus Metadata #12059
Validate Automatus Metadata #12059
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Validate metadata used by Automatus.
The script uses root_dir which is in 3.10+
37500b9
to
d2939f2
Compare
d2939f2
to
cd8e120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified multiple test scenarios and run the test. It failed successfully when I have messed the metadata. I have also seen that this test has been run in the CI job "Build, Test Fedora Latest" and passes there.
It's a great contribution!
...s-physical/screen_locking/smart_card_login/smartcard_configure_crl/tests/missing_crl.fail.sh
Outdated
Show resolved
Hide resolved
…g/smart_card_login/smartcard_configure_crl/tests/missing_crl.fail.sh Co-authored-by: Jan Černý <jcerny@redhat.com>
Code Climate has analyzed commit e65fccb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failed on SLE15 because the tested rules are not part of SLE 15 content, on Ubuntu because xsltproc isn't present there, on CS8 because CS 8 is sunset, on CS 9 because the tested rules aren't part of RHEL 9 content, on Fedora because the required packages of rules smartcard_configure_crl and check_ufw_active aren't available on Fedora. None of these fails are caused by the contents of this PR.
Description:
Rationale:
Requested in #12057
Review Hints:
invalld.notafail.sh
and observe the failureplatforms
and see the failure