Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Automatus Metadata #12059

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jun 12, 2024

Description:

  • Add test to validate metadata for Automatus
  • Fix existing errors

Rationale:

Requested in #12057

Review Hints:

  • Move your favorite test to something like invalld.notafail.sh and observe the failure
  • Update a metadata key on your favorite to platforms and see the failure

@Mab879 Mab879 added the Test Suite Update in Test Suite. label Jun 12, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jun 12, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 12, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12059
This image was built from commit: e65fccb

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12059

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12059 make deploy-local

@Mab879 Mab879 force-pushed the validate_automatus_metadata branch from 37500b9 to d2939f2 Compare June 14, 2024 20:24
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified multiple test scenarios and run the test. It failed successfully when I have messed the metadata. I have also seen that this test has been run in the CI job "Build, Test Fedora Latest" and passes there.

It's a great contribution!

…g/smart_card_login/smartcard_configure_crl/tests/missing_crl.fail.sh

Co-authored-by: Jan Černý <jcerny@redhat.com>
@Mab879 Mab879 requested a review from jan-cerny June 20, 2024 18:44
Copy link

codeclimate bot commented Jun 20, 2024

Code Climate has analyzed commit e65fccb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failed on SLE15 because the tested rules are not part of SLE 15 content, on Ubuntu because xsltproc isn't present there, on CS8 because CS 8 is sunset, on CS 9 because the tested rules aren't part of RHEL 9 content, on Fedora because the required packages of rules smartcard_configure_crl and check_ufw_active aren't available on Fedora. None of these fails are caused by the contents of this PR.

@jan-cerny jan-cerny merged commit c779035 into ComplianceAsCode:master Jun 21, 2024
87 of 93 checks passed
@Mab879 Mab879 deleted the validate_automatus_metadata branch June 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants