-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CIS RHEL9 control file to v2.0.0 #12067
Update CIS RHEL9 control file to v2.0.0 #12067
Conversation
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
CIS RHEL9 v2.0.0
Skipping CI for Draft Pull Request. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
All rules in Section 6.2.3 should be under related_rules
. Section 6.2 is a pick one section, like the firewall section.
There are conflicting requirements regarding journald and rsyslog. JournalD is the default preference for RHEL 9. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
CIS RHEL 9 v2.0.0 Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take look the testing farm failures, they look valid enough to investigate.
Ensure rules no longer used in RHEL 9 profiles are kept in the Datastream to avoid breaking eventual tailoring files.
Code Climate has analyzed commit fc85059 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Thanks for reviewing @Mab879 . The failures should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort on this PR.
LGTM.
Description:
This PR update the controls based on CIS RHEL9 v2.0.0.
A new version of CIS RHEL9 policy is in
Accepted
state and is expected to move topublished
state in 2024-06-20.Until the policy is moved to
published
state I will keep this PR in Draft. But it is already good for review.Rationale:
Keep CIS RHEL9 profiles updated.
Review Hints:
Best way to review is going commit by commit chronologically. The commits are ordering according to the order the requirements are presented in the policy.
References:
https://workbench.cisecurity.org/benchmarks/18210