Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dconf db directory for local profile #12079

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Make sure the corresponding database directories exist for user profile

Rationale:

  • The enable_dconf_user_profile rule need create user profile for screenlock,automount,ctrlaltdel,... settings, but doesn't create the local.d db directory automatically which causes the dconf to throw out warning

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 19, 2024
Copy link

openshift-ci bot commented Jun 19, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12079
This image was built from commit: da4cf3c

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12079

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12079 make deploy-local

Copy link

codeclimate bot commented Jun 19, 2024

Code Climate has analyzed commit da4cf3c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jun 20, 2024
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jun 20, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail on Fedora Rawhide is a problem in dnf, fail on Ubuntu 22.04 is caused by missing xmllint and will be fixed by #12080, fail on CS 8 is caused by the CS 8 sunset.
All of these fails aren't caused by the contents of this PR.

@jan-cerny jan-cerny merged commit 30252ad into ComplianceAsCode:master Jun 20, 2024
84 of 88 checks passed
@Mab879 Mab879 added the Bash Bash remediation update. label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants