Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OVAL readability in auditd_audispd_configure_sufficiently_large_partition #12083

Merged

Conversation

marcusburghardt
Copy link
Member

Description:

Minor OVAL updates in auditd_audispd_configure_sufficiently_large_partition regarding readability only.

Rationale:

This commit was part of a PR (#11903) I closed in the past, but I think it is good bring these specific changes anyways since it was already done.

Minor OVAL updates in auditd_audispd_configure_sufficiently_large_partition regarding
readability only.
@marcusburghardt marcusburghardt added the OVAL OVAL update. Related to the systems assessments. label Jun 20, 2024
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone Jun 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 20, 2024
Copy link

openshift-ci bot commented Jun 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@marcusburghardt marcusburghardt marked this pull request as ready for review June 20, 2024 11:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 20, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12083
This image was built from commit: ffa773c

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12083

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12083 make deploy-local

Copy link

codeclimate bot commented Jun 20, 2024

Code Climate has analyzed commit ffa773c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jun 21, 2024
@Mab879
Copy link
Member

Mab879 commented Jun 21, 2024

Waving

  • Automatus Ubuntu 22.04 this is not related to this PR
  • Fedora Rawhide - Expected, not related to this PR.
  • Automatus CS8 - Expected, due to c8s status

@Mab879 Mab879 merged commit 7ce6a1d into ComplianceAsCode:master Jun 21, 2024
90 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OVAL OVAL update. Related to the systems assessments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants