-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Filename for UBI test #12115
Fix Filename for UBI test #12115
Conversation
Skipping CI for Draft Pull Request. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
@Mab879 the UBI8 job runs and doesn't fail but the rule is evaluated as "notapplicable", is that expected? |
/packit reset-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a comment, would it be interesting to also rename the automatus-cs8.yaml
file to automatus-ubi8.yaml
?
/packit build |
Due to the reduced package set in UBI 8, that seems to be expected.
|
So moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please remove the example test scenario now.
Done |
Code Climate has analyzed commit 6aad455 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/packit build |
Description:
I introduced a minor bug in the Automatus UBI8 test in #12100, this should fix that.
Rationale:
So the tests work.
Review Hints: