-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates: add rhel10 to conditional macros where rhel9 is mentioned #12156
templates: add rhel10 to conditional macros where rhel9 is mentioned #12156
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
I ran
|
@Mab879 I mention it in "Review hints". Yes, it is expected. The rule grub2_kernel_trust_cpu_rng is not affected by this PR. |
Code Climate has analyzed commit a5260ef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description:
Rationale:
Review Hints:
Tests should pass. Note that when testing grub2_bootloader_argument, there will be one rule failing; grub2_kernel_trust_cpu_rng. This rule should not be affected by this PR, because the PR modifies the template OVAL but this particular rule has its own OVAL. Nevertheless, it is broken on RHEL 10 and should be reported as an issue.