Update OVAL check in accounts_password_last_change_is_in_past #12177
Conversation
Previously, this test was using a hard-coded value to compare the timestamp of password last change field. This approach works fine in most cases but proved not robust enough when passwords were changed long time ago. The new approach uses the current timestamp instead of a hard-coded value for a more flexible and robust test. Essentially only the variable_state object was updated, but the ids of some other objects were renamed for better alignment between objects ids. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
This test scenario is not so realistic but is important to test the OVAL logic used in this rule, which was previously using a hard-coded value to compare the timestamps. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
added
bugfix
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit 14cf142 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
/packit retest-failed |
Description:
Previously, this test was using a hard-coded value to compare the timestamp of password last change field.
This approach works fine in most cases but proved not robust enough when passwords were changed long time ago. The new approach uses the current timestamp instead of a hard-coded value for a more flexible and robust test.
Rationale:
Review Hints:
Essentially only the
variable_stateobject was updated to use a new local variable instead of a hard-coded value.The ids of some other objects were renamed for better alignment between objects ids, without technical changes in logic.
There is no remediation for this rule, so automatus tests should be enough. e.g.: