Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package_dnf-plugin-subscription-manager_installed in RHEL 10 #12180

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 17, 2024

Description:

  • New rule package_libdnf-plugin-subscription-manager_installed
  • Only use package_libdnf-plugin-subscription-manager_installed in RHEL 10

Rationale:

Fixes #12168

@Mab879 Mab879 added New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jul 17, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 17, 2024
@Mab879 Mab879 requested a review from a team as a code owner July 17, 2024 21:01
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel10 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
xccdf_org.ssgproject.content_rule_package_dnf-plugin-subscription-manager_installed is missing in new data stream.

Copy link

github-actions bot commented Jul 17, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12180
This image was built from commit: 064a604

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12180

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12180 make deploy-local

@Mab879 Mab879 marked this pull request as draft July 17, 2024 23:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 17, 2024
@Mab879 Mab879 marked this pull request as ready for review July 18, 2024 19:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 18, 2024
@jan-cerny jan-cerny self-assigned this Jul 19, 2024
@jan-cerny
Copy link
Collaborator

@Mab879 please rebase the PR

@Mab879
Copy link
Member Author

Mab879 commented Jul 19, 2024

@Mab879 please rebase the PR

Done

Copy link

codeclimate bot commented Jul 19, 2024

Code Climate has analyzed commit 064a604 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the RHEL 10 content and I have checked that the rule is there.

@jan-cerny jan-cerny merged commit 65f70bf into ComplianceAsCode:master Jul 19, 2024
90 of 95 checks passed
@Mab879 Mab879 deleted the fix_12168 branch July 19, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Rule Issues or pull requests related to new Rules. RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No package dnf-plugin-subscription-manager available
2 participants