Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH related STIG rule to slmicro5 platform #12193

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Jul 22, 2024

Description:

Added following rules to SLE Micro 5 platform

  • 'Record Events that Modify User/Group Information - /etc/passwd'
  • 'Disable SSH Access via Empty Passwords'
  • 'Disable SSH Root Login'
  • 'Disable SSH Support for User Known Hosts'
  • 'Disable X11 Forwarding'
  • 'Do Not Allow SSH Environment Options'
  • 'Enable Use of Strict Mode Checking'
  • 'Enable SSH Warning Banner'
  • 'Enable SSH Print Last Log'
  • 'Set SSH Daemon LogLevel to VERBOSE'

Rationale:

  • With this update we will extend the rule to support new product SLE Micro 5

Review Hints:

  • Drop PRs from 12193 to 12204

Copy link

openshift-ci bot commented Jul 22, 2024

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 22, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 22, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12193
This image was built from commit: 41b28b2

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12193

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12193 make deploy-local

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as draft July 24, 2024 04:45
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 24, 2024
@teacup-on-rockingchair teacup-on-rockingchair changed the title Updated rule 'Record Events that Modify User/Group Information - /etc… Add SSH related STIG rule to slmicro5 platform Jul 24, 2024
@teacup-on-rockingchair teacup-on-rockingchair added Update Rule Issues or pull requests related to Rules updates. STIG STIG Benchmark related. labels Jul 24, 2024
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review July 24, 2024 05:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 24, 2024
Copy link

codeclimate bot commented Jul 24, 2024

Code Climate has analyzed commit 41b28b2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok 👍 and does not break other platforms

@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.74 milestone Jul 24, 2024
@teacup-on-rockingchair teacup-on-rockingchair merged commit 597d9ab into ComplianceAsCode:master Jul 24, 2024
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants