Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the platform for rule package_iptables-persistent_removed #12195

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Correct the platform detection for rule package_iptables-persistent_removed

Rationale:

  • As the cis rule indicates: remove iptables-persistent if ufw is installed

As the cis rule indicates: remove iptables-persistent if ufw is installed
Copy link

openshift-ci bot commented Jul 22, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 22, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 22, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12195
This image was built from commit: f67338c

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12195

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12195 make deploy-local

Copy link

codeclimate bot commented Jul 22, 2024

Code Climate has analyzed commit f67338c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added this to the 0.1.74 milestone Jul 24, 2024
@jan-cerny jan-cerny self-assigned this Jul 24, 2024
@jan-cerny jan-cerny merged commit 34e0e79 into ComplianceAsCode:master Jul 24, 2024
89 of 90 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Aug 8, 2024
@Mab879 Mab879 changed the title Correct the platform Correct the platform for rule package_iptables-persistent_removed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants