Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable service_enabled templated test for service_bluetooth_disabled #12211

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Jul 23, 2024

Description:

Disable test scenario that tries to start bluetooth service and then expect it to fail.

Rationale:

The service is dependent on loaded btusb kernel module. However, this module is not loaded by default and templated test scenario doesn't load it either.

We had similar problem in the past #11949 and now it started happening also on RHEL 8.8 and 9.2. I tried it manually on those systems and to properly start the service, I had to modprobe btusb (https://wiki.archlinux.org/title/Bluetooth#Installation). It will be better to disable the test scenario completely rather than creating Contest waiver.

Review Hints:

Try Automatus for service_bluetooth_disabled and see what test scenarios are not run.

@mildas mildas added the Test Suite Update in Test Suite. label Jul 23, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12211
This image was built from commit: 2234dcc

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12211

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12211 make deploy-local

@Mab879 Mab879 self-assigned this Jul 23, 2024
Copy link

codeclimate bot commented Jul 23, 2024

Code Climate has analyzed commit 2234dcc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.74 milestone Jul 23, 2024
@Mab879 Mab879 merged commit f82c486 into ComplianceAsCode:master Jul 23, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants