Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft status to all RHEL 10 profiles #12224

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 25, 2024

Description:

Add draft status to all RHEL 10 profiles

Rationale:

Prepare for RHEL 10.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jul 25, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 25, 2024
@Mab879 Mab879 requested a review from a team as a code owner July 25, 2024 16:41
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 25, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12224
This image was built from commit: 6615b9f

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12224

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12224 make deploy-local

@jan-cerny jan-cerny self-assigned this Jul 29, 2024
@@ -11,10 +11,11 @@ reference: https://www.niap-ccevs.org/Profile/Info.cfm?PPID=469&id=469
title: 'DRAFT - Protection Profile for General Purpose Operating Systems'

description: |-
This profile is part of Red Hat Enterprise Linux 9 Common Criteria Guidance
This is draft profile is not based on the Red Hat Enterprise Linux 10 riteria Guidance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This draft profile is not based on the Red Hat Enterprise Linux 10 Common Criteria Guidance

documentation for Target of Evaluation based on Protection Profile for
General Purpose Operating Systems (OSPP) version 4.3 and Functional
Package for SSH version 1.0.
General Purpose Operating Systems was it not available not the time of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it was not available at the time of the release.

@@ -11,10 +11,11 @@ reference: https://www.niap-ccevs.org/Profile/Info.cfm?PPID=469&id=469
title: 'DRAFT - Protection Profile for General Purpose Operating Systems'

description: |-
This profile is part of Red Hat Enterprise Linux 9 Common Criteria Guidance
This is draft profile is not based on the Red Hat Enterprise Linux 10 riteria Guidance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description doesn't make sense, please reword.

@Mab879 Mab879 requested a review from jan-cerny July 29, 2024 12:08
Co-authored-by: Marcus Burghardt <2074099+marcusburghardt@users.noreply.github.com>
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Mab879

Copy link

codeclimate bot commented Jul 29, 2024

Code Climate has analyzed commit 6615b9f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit f2e34f9 into ComplianceAsCode:master Jul 29, 2024
95 of 96 checks passed
@Mab879 Mab879 deleted the draft_all_rhel_10 branch July 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants