Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map more rules into Anssi policy #4439

Merged
merged 16 commits into from
Jun 25, 2019

Conversation

yuumasato
Copy link
Member

Description:

  • Maps rules into ANSSI requirements
  • Select mapped rules in profile corresponding to hardening level

@matejak matejak self-assigned this Jun 25, 2019
@matejak matejak added this to the 0.1.45 milestone Jun 25, 2019
@matejak
Copy link
Member

matejak commented Jun 25, 2019

It looks like that we have double-selection of rules sysctl_fs_suid_dumpable and sysctl_kernel_randomize_va_space.

@@ -22,6 +35,16 @@ selections:
- sysctl_fs_suid_dumpable
- sysctl_kernel_randomize_va_space
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first occurrence of both

- sysctl_fs_protected_hardlinks

# Activation of the ASLR
- sysctl_kernel_randomize_va_space
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second occurrence

# kernel. sysrq = 0

# No core dump of executable setuid
- sysctl_fs_suid_dumpable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second occurrence

@yuumasato
Copy link
Member Author

@matejak Thanks for review, and nice catch.
The duplicated rules have been removed.

@matejak
Copy link
Member

matejak commented Jun 25, 2019

Thanks for improving the ANSSI profile set!

@matejak matejak merged commit 8f0a2a5 into ComplianceAsCode:master Jun 25, 2019
@yuumasato yuumasato deleted the anssi_mappings branch June 25, 2019 13:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants