Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configure_crypto_policy set DEFAULT test scenario for RHEL8. #4443

Conversation

ggbecker
Copy link
Member

Enable set DEFAULT configure_crypto_policy test scenario for RHEL8.

@ggbecker ggbecker added this to the 0.1.45 milestone Jun 24, 2019
@ggbecker ggbecker changed the title Enable configure_crypto_policy set DEFAULT test scenario to RHEL8. Enable configure_crypto_policy set DEFAULT test scenario for RHEL8. Jun 24, 2019
@mildas
Copy link
Contributor

mildas commented Jun 25, 2019

What about other test scenarios for configure_crypto_policy?

@mildas mildas self-assigned this Jun 25, 2019
@ggbecker
Copy link
Member Author

What about other test scenarios for configure_crypto_policy?

The other test scenarios are already configured to run for RHEL8, e.g.:

@mildas
Copy link
Contributor

mildas commented Jun 25, 2019

@ggbecker Ah, okay.
I have one question - does this test make sense? I mean the test sets crypto policies to DEFAULT, but OVAL expects FIPS value, so the test fails every time although it should pass (*.pass.sh). It would make sense for profile, that wants DEFAULT, but I didn't find any and it fails at fedora too.

@ggbecker
Copy link
Member Author

@ggbecker Ah, okay.
I have one question - does this test make sense? I mean the test sets crypto policies to DEFAULT, but OVAL expects FIPS value, so the test fails every time although it should pass (*.pass.sh). It would make sense for profile, that wants DEFAULT, but I didn't find any and it fails at fedora too.

It makes sense only for the standard profile which uses default variable for this rule (DEFAULT). So we can just remove the OSPP profile from profiles header and it'll be ok.

@mildas
Copy link
Contributor

mildas commented Jun 25, 2019

Looks good, I will merge it after build passing.

@mildas mildas merged commit b41837f into ComplianceAsCode:master Jun 26, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants