install_vm.py: fix for osinfo-detect not working under sudo/su #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue in osinfo-detect https://gitlab.com/libosinfo/libosinfo/issues/30 was preventing the script to install RHEL distros under sudo/su. This commit fixes it and implements simpler logic for adding repositories into the kickstart.
matusmarhefka
force-pushed
the
fix_install_vm_os_detect
branch
from
70bac9e
to
1b00397
Compare
|
Hello @matusmarhefka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-06-28 13:23:51 UTC |
ggbecker
reviewed
Jun 28, 2019
|
LGTM. Thanks for the patch. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The issue in osinfo-detect https://gitlab.com/libosinfo/libosinfo/issues/30
was preventing the script to install RHEL distros under sudo/su. This commit
fixes it and implements simpler logic for adding repositories into the
kickstart.