Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the usbguard service in OSPP profiles. #4611

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Enable the usbguard service in OSPP profiles. #4611

merged 1 commit into from
Jul 15, 2019

Conversation

adelton
Copy link
Collaborator

@adelton adelton commented Jul 11, 2019

Description:

  • Enable the usbguard service in OSPP profiles.

Rationale:

  • Presumably it increases security.

jan-cerny
jan-cerny reviewed Jul 12, 2019
View reviewed changes
linux_os/guide/services/usbguard/service_usbguard_enabled/rule.yml Outdated
The USBGuard service should be enabled.
{{{ describe_service_enable(service="usbguard") }}}

rationale: ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically explain why we suggest using the service. Check eg. rules service_chronyd_or_ntpd_enabled, service_rsyslog_enabled, service_firewalld_enabled for inspiration.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've checked service_sssd_enabled and that is very silent about the rationale ...

@adelton
Copy link
Collaborator Author

adelton commented Jul 15, 2019

Added rationale, rebase on master -> 33286d9.

@jan-cerny jan-cerny self-assigned this Jul 15, 2019
@jan-cerny
Copy link
Collaborator

@openscap-ci test this please

@jan-cerny jan-cerny added this to the 0.1.45 milestone Jul 15, 2019
@jan-cerny jan-cerny merged commit 97ab483 into ComplianceAsCode:master Jul 15, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny left review comments

Assignees

@jan-cerny jan-cerny

Labels
None yet
Projects
None yet
Milestone
0.1.45
Development

Successfully merging this pull request may close these issues.
2 participants
@adelton @jan-cerny