Test suite autodetect datastream. #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frequent use case is that a single datastream is built in the build directory, and one wants it to be tested by the test suite. This change add autodetection capabilities, so the --datastream option can be left out. If it is left out and there is not a single datastream in the build dir, an error is displayed instead.
yuumasato
requested changes
Jul 25, 2019
tests/test_suite.py
Outdated
| if len(datastreams) == 1: | ||
| return datastreams[0] | ||
| msg = ("Unable to auto-detect the datastream, " | ||
| "expected to find a single one in the build dir, but") |
There was a problem hiding this comment.
I wouldn't say that it is expected that there is only single datastream in build dir, I have othen more than one.
tests/test_suite.py
Outdated
| if not datastreams: | ||
| raise RuntimeError(msg + " found none.") | ||
| raise RuntimeError( | ||
| msg + " found multiple ones: {0}".format(datastreams)) |
There was a problem hiding this comment.
If multiple DataStreams are found, the tool should recommend use of --datastream option.
|
Thanks for the feedback, comments are addressed. |
yuumasato
reviewed
Jul 25, 2019
| raise RuntimeError( | ||
| msg + " found multiple ones: {0}".format(datastreams)) | ||
| msg + " there are {0} of them. Use the --datastream option to select " |
There was a problem hiding this comment.
The line can get rather long:
Setting console output to log level INFO
ERROR - Error occurred during options normalization: Autodetection of the datastream file is possible only when there is a single one in the build dir, but there are 28 of them. Use the --datastream option to select e.g. ['../build/ssg-debian8-ds.xml', '../build/ssg-rhel7-ds.xml', '../build/ssg-wrlinux8-ds.xml', '../build/ssg-wrlinux1019-ds.xml', '../build/ssg-ubuntu1404-ds.xml', '../build/ssg-ol8-ds.xml', '../build/ssg-centos6-ds.xml', '../build/ssg-fuse6-ds.xml', '../build/ssg-centos7-ds.xml', '../build/ssg-eap6-ds.xml', '../build/ssg-ubuntu1604-ds.xml', '../build/ssg-ubuntu1804-ds.xml', '../build/ssg-rhv4-ds.xml', '../build/ssg-rhosp13-ds.xml', '../build/ssg-chromium-ds.xml', '../build/ssg-fedora-ds.xml', '../build/ssg-ol7-ds.xml', '../build/ssg-sl6-ds.xml', '../build/ssg-rhel8-ds.xml', '../build/ssg-sle12-ds.xml', '../build/ssg-firefox-ds.xml', '../build/ssg-sl7-ds.xml', '../build/ssg-sle11-ds.xml', '../build/ssg-rhel6-ds.xml', '../build/ssg-opensuse-ds.xml', '../build/ssg-jre-ds.xml', '../build/ssg-ocp3-ds.xml', '../build/ssg-centos8-ds.xml']And in the terminal it actually wraps up.
I like that they short and easy to copy-paste when adding --datastream option.
yuumasato
approved these changes
Jul 25, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frequent use case is that a single datastream is built in the build directory, and one wants it to be tested by the test suite.
This change add autodetection capabilities, so the --datastream option can be left out. If it is left out and there is not a single datastream in the build dir, an error is displayed instead.
As a side-effect, the
--datastreamoption won't be required any longer, which is generally recommended.