Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused/unwanted dconf_use_text_backend rule. #4684

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Delete unused/unwanted dconf_use_text_backend rule. #4684

merged 2 commits into from
Aug 8, 2019

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Aug 7, 2019

Description:

  • As part of previous dconf bugfix, the first attempt was to set dconf to use text backend as its database. It turned out that this didn't solve the problem thus leaving this rule as unused/unwanted. I propose to remove all artifacts related to it.

Rationale:

  • Remove unused/unwanted dconf_use_text_backend rule.

@ggbecker ggbecker added this to the 0.1.46 milestone Aug 7, 2019
@ggbecker
Copy link
Member Author

ggbecker commented Aug 8, 2019

@openscap-ci test this please

ggbecker
ggbecker commented Aug 8, 2019
View reviewed changes
shared/references/cce-redhat-avail.txt Outdated
@@ -706,3 +706,4 @@ CCE-82900-2
CCE-82901-0
CCE-82902-8
CCE-82903-6
CCE-80782-6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returns back the CCE to the available pool of numbers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove as it was part of at least 0.1.45 release and could cause conflict.

@yuumasato
Copy link
Member

LGTM.
I'm just not sure about returning the CCE to the pool, as the rule is part of release 0.1.45.

@ggbecker
Copy link
Member Author

ggbecker commented Aug 8, 2019

I'm just not sure about returning the CCE to the pool, as the rule is part of release 0.1.45.

That's true, it doesn't make sense to return it to the pool. I'll remove it.

@ggbecker
Remove used CCE from pool.
8460169 
The rule who had it assigned was part of at least 0.1.45 release.
@matejak
Copy link
Member

matejak commented Aug 8, 2019

LGTM, thank you for this cleanup!

@matejak matejak merged commit 07f23b0 into ComplianceAsCode:master Aug 8, 2019
@ggbecker ggbecker deleted the delete-unused-dconf-rule branch August 27, 2019 11:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matejak matejak

Labels
None yet
Projects
None yet
Milestone
0.1.46
Development

Successfully merging this pull request may close these issues.
3 participants
@ggbecker @yuumasato @matejak