-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSPP consolidation #4705
OSPP consolidation #4705
Conversation
As there are significant shuffling changes, please review per commit. I have tried to make it clear and readable. |
eb72d1b
to
f332044
Compare
Is the |
I've used the abbreviation I got from the discussion notes with @shawndwells It might be a typo though. Shawn, can you confirm? :) |
I have created blocker issue to track the rename of |
On 8/10/19 9:32 AM, Marek Haičman wrote:
Is the |nccp| profile for the NIST National Checklist Program? If
so, should be |ncp|.
I've used the abbreviation I got from the discussion notes with
@shawndwells <https://github.com/shawndwells> It might be a typo
though. Shawn, can you confirm? :)
NIST National Checklist Program.... nncp.
But IIRC this was intended to be a working title and we have all of
August to figure out something more permanent.
|
NIST calls it the National Checklist Program and abbreviates it as NCP, so why not just go with that (make it lower case of course)? It's simple and lines up with NIST's abbreviation and will avoid confusion in addition to it possibly being viewed as a typo if it is |
we are moving it to another identifier. This is to make space for real pure OSPP profile.
f332044
to
758a7b0
Compare
I've reuploaded to fix merge conflicts - this time, I haven't extended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very glad that we are consolidating these profiles.
Thank you for the patch, @dahaic.
@dahaic Please, also update the test for stable IDs. |
…e of OSPP v4.2.1. There should be nothing more and nothing less. Removing profiles with identifiers `ccc` and `ospp42` as these were just development artifacts.
758a7b0
to
1506f91
Compare
Description:
ccc
ospp
andospp42
profiles in RHEL7 product should no longer occur. New split is betweenospp
profile, which closely follows OSPP guidance, andncp
profile, which inherits generality of the old profile underospp
id.