Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPP consolidation #4705

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Conversation

dahaic
Copy link
Contributor

@dahaic dahaic commented Aug 9, 2019

Description:

  • Confusion caused by ccc ospp and ospp42 profiles in RHEL7 product should no longer occur. New split is between ospp profile, which closely follows OSPP guidance, and ncp profile, which inherits generality of the old profile under ospp id.

@dahaic
Copy link
Contributor Author

dahaic commented Aug 9, 2019

As there are significant shuffling changes, please review per commit. I have tried to make it clear and readable.

@redhatrises
Copy link
Contributor

Is the nccp profile for the NIST National Checklist Program? If so, should be ncp.

@dahaic
Copy link
Contributor Author

dahaic commented Aug 10, 2019

Is the nccp profile for the NIST National Checklist Program? If so, should be ncp.

I've used the abbreviation I got from the discussion notes with @shawndwells It might be a typo though. Shawn, can you confirm? :)

@jan-cerny jan-cerny changed the title Ospp consolidation OSPP consolidation Aug 12, 2019
@dahaic
Copy link
Contributor Author

dahaic commented Aug 12, 2019

I have created blocker issue to track the rename of nccp to anything else. Thus I believe this PR is not blocked anymore.

@shawndwells
Copy link
Member

shawndwells commented Aug 12, 2019 via email

@redhatrises
Copy link
Contributor

On 8/10/19 9:32 AM, Marek Haičman wrote: Is the |nccp| profile for the NIST National Checklist Program? If so, should be |ncp|. I've used the abbreviation I got from the discussion notes with @shawndwells https://github.com/shawndwells It might be a typo though. Shawn, can you confirm? :)
NIST National Checklist Program.... nncp. But IIRC this was intended to be a working title and we have all of August to figure out something more permanent.

NIST calls it the National Checklist Program and abbreviates it as NCP, so why not just go with that (make it lower case of course)? It's simple and lines up with NIST's abbreviation and will avoid confusion in addition to it possibly being viewed as a typo if it is nncp.

we are moving it to another identifier.

This is to make space for real pure OSPP profile.
@dahaic
Copy link
Contributor Author

dahaic commented Aug 14, 2019

I've reuploaded to fix merge conflicts - this time, I haven't extended ncp profile with ospp one - will do that after this PR is merged.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very glad that we are consolidating these profiles.
Thank you for the patch, @dahaic.

@yuumasato
Copy link
Member

@dahaic Please, also update the test for stable IDs.

…e of

OSPP v4.2.1. There should be nothing more and nothing less.

Removing profiles with identifiers `ccc` and `ospp42` as these were just
development artifacts.
@yuumasato yuumasato self-assigned this Aug 14, 2019
@yuumasato yuumasato added this to the 0.1.46 milestone Aug 14, 2019
@yuumasato yuumasato merged commit ecf9684 into ComplianceAsCode:master Aug 14, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants