Disable Kerberos by removing host keytab. #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
requested changes
Sep 4, 2019
| description: |- | ||
| Kerberos is not an approved key distribution method for | ||
| Common Criteria. To prevent using Kerberos by system daemons, | ||
| remove the host keytab <tt>/etc/krb5.keytab</tt>. |
There was a problem hiding this comment.
The description mentions specifically /etc/krb5.keytab but the OVAL uses a wildcard and checks any file in /etc which name ends with .keytab.
| </definition> | ||
|
|
||
| <unix:file_object id="obj_kerberos_disable_no_keytab" version="1" comment="fapolicyd.mounts"> | ||
| <unix:filepath operation="pattern match">/etc/*.keytab</unix:filepath> |
There was a problem hiding this comment.
The regular expression should be ^/etc/.*\.keytab$.
| <description>Check that there is no Kerberos keytab file present in /etc</description> | ||
| </metadata> | ||
| <criteria> | ||
| <criterion test_ref="test_kerberos_disable_no_keytab" negate="true" |
There was a problem hiding this comment.
I think instead of using negation, you can set check="all" check_existence="none_exist" in the file_test element and remove the negate attribute. However, your solution works for me as well.
|
@openscap-ci test this please |
adelton
force-pushed
the
kerberos_disable_no_keytab
branch
from
7155906
to
7511e33
Compare
|
Addressed the comments -> 7511e33. Sorry about that, I thought I had the patch updated and pushed before creating the PR but evidently I did not. |
|
@openscap-ci test this please |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale: