Made templates product-specific. #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template variables and backends can be product-qualified. Value of foo@rhel7 overwrites foo on rhel7, while value of foo will be the default for other products.
jan-cerny
approved these changes
Sep 16, 2019
| not_specific_backends = self.template.get("backends", dict()) | ||
| specific_backends = self._make_items_product_specific( | ||
| not_specific_backends, product_suffix, True) | ||
| self.template["backends"] = specific_backends |
There was a problem hiding this comment.
Note to myself: This means that "backends" will be always defined, so i we have some time we can drop the else branch or update the code in https://github.com/ComplianceAsCode/content/blob/master/ssg/templates.py#L152
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template variables and backends can be product-qualified.
Value of foo@rhel7 overwrites foo on rhel7, while value of foo will be the default
for other products.
Needed for #4820 to work properly.