Made the new templating system work with Python2.6. #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
reviewed
Oct 4, 2019
ssg/templates.py
Outdated
| uppercases = dict() | ||
| for k, v in parameters.items(): | ||
| uppercases[k.upper()] = v | ||
| parameters.update(uppercases) |
There was a problem hiding this comment.
I'd prefer to return uppercases right away.
|
Why support python2.6? |
|
@konstruktoid Because Red Hat Enterprise Linux 6 has only Python 2.6, and we still support building on RHEL6. |
matejak
force-pushed
the
new_templates_rhel6
branch
from
beaef4e
to
f8b0d8d
Compare
|
I have rebased, so no more updating of the dict with uppercase keys - now only the uppercase dict is returned. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.6 doesn't allow dict comprehensions.
Also the
package_gcc_installedrule has been removed, as it was introduced for demonstration purposes only and the unquoted YAML bool causes problems on Python2.