Add unit test for kubernetes object remediations #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test that will iterate through all the relevant remediations that are kubernetes objects and will verify if they're correctly formed or not.
JAORMX
added a commit
to JAORMX/content
that referenced
this pull request
Apr 17, 2020
Some audit related Machineconfig objects were introduced as ignition
remediations. They were malformed. This fixes that.
This makes the unit tests pass. Which can be verified as follows:
make -f tests/unit/kubernetes/Makefile unit
These tests were recently introduced in the following PR: ComplianceAsCode#5636
JAORMX
added a commit
that referenced
this pull request
Apr 17, 2020
Some audit related Machineconfig objects were introduced as ignition
remediations. They were malformed. This fixes that.
This makes the unit tests pass. Which can be verified as follows:
make -f tests/unit/kubernetes/Makefile unit
These tests were recently introduced in the following PR: #5636
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test that will iterate through all the relevant remediations
that are kubernetes objects and will verify if they're correctly formed
or not.