Add Ansible for kernel_module_ipv6_option_disabled #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mildas Could the bot have its own account? |
|
@mildas People might think that you're a bot 😄 |
vojtapolasek
reviewed
May 5, 2020
| #!/bin/bash | ||
| # platform = Red Hat Enterprise Linux 7 | ||
|
|
||
| echo "options ipv6 disable=1" > /etc/modprobe.d/ipv6.conf |
There was a problem hiding this comment.
The test is named module_and_sysctl_disabled... but I don't see anything about sysctl in this test. Is the sysctl option disabled by default?
The remediation does more than disabling only one kernel module, so it is not suitable for "templation" (use of templating system).
yuumasato
force-pushed
the
audit_kernel_module_ipv6_option_disable
branch
from
e611a54
to
e14418e
Compare
|
Changes identified: Recommended tests to execute: |
|
Thank you, approving. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
kernel_module_ipv6_option_disabledthat closely follows behavior of Bash remediation.Notes:
The remediation of this rule also sets sysctl
disable_ipv6to1, as some other module may be pulling in the module as a dependency.Reference: https://access.redhat.com/solutions/72733.
The remediation does more than disabling only one kernel module, so it is not suitable for "templation" (use of templating system).