OCP4: Add remediation equality unit tests #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needed to be fixed manually since without the fix we won't read MachineConfigs properly. Co-Authored-By: Jakub Hrozek <jhrozek@redhat.com>
If a file is changed in MachineConfig, it needs to have the same contents, else the machine-config-operator won't be able to properly reconcile the file. Co-Authored-By: Jakub Hrozek <jhrozek@redhat.com>
Without this flag, running unit tests locally might give cached results, which might be stale. Co-Authored-By: Jakub Hrozek <jhrozek@redhat.com>
|
@openscap-ci test this please |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests check that remediations don't change files in inconsistent ways. This way we can keep a golden configuration for a specific service, and so remediations will work in the way that machine-config-operator expects.