Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cis partitions rules #5749

Merged
merged 4 commits into from
May 12, 2020
Merged

Cis partitions rules #5749

merged 4 commits into from
May 12, 2020

Conversation

willumpie
Copy link
Contributor

Description:

  • Add partitions rules for the CIS profile for Ubuntu 1804

Rationale:

Make rules available for Ubuntu 1804

@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@pep8speaks
Copy link

Hello @willumpie! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 504:100: E501 line too long (126 > 99 characters)

@openshift-ci-robot openshift-ci-robot added needs-rebase Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels May 8, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @willumpie. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Used by openshift-ci bot. label May 8, 2020
@redhatrises
Copy link
Contributor

@willumpie can do a rebase please? We would like to not have all the extra commits in this PR. Makes it very hard to review.

@willumpie
Copy link
Contributor Author

@willumpie can do a rebase please? We would like to not have all the extra commits in this PR. Makes it very hard to review.
Of course.

@willumpie
Copy link
Contributor Author

@redhatrises can do a rebase please? We would like to not have all the extra commits in this PR. Makes it very hard to review.

I merged my fork according the github tutorial. sorry.
Now rebased it and removed unneccesary commits.

jan-cerny
jan-cerny reviewed May 11, 2020
View reviewed changes
linux_os/guide/system/permissions/partitions/mount_option_home_nodev/rule.yml Outdated
anssi: NT28(R12)
srg: SRG-OS-000368-GPOS-00154
cis@sle15: 1.1.15
cis@ubuntu1804: 1.1.13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is twice here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay, duplicate. I will remove it

linux_os/guide/system/permissions/partitions/mount_option_tmp_noexec/rule.yml Outdated
@@ -1,6 +1,6 @@
documentation_complete: true

prodtype: fedora,ol7,ol8,rhel6,rhel7,rhel8,sle15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is sle15 removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be part of the merging and rebasing issues.
It was not my intention to remove it.
I will restore it.

linux_os/guide/system/permissions/partitions/mount_option_tmp_noexec/rule.yml
@@ -37,7 +37,6 @@ references:
cis-csc: 11,13,14,3,8,9
anssi: NT28(R12)
srg: SRG-OS-000368-GPOS-00154
cis@sle15: 1.1.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sle15 removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored

@jan-cerny
Copy link
Collaborator

@openscap-ci ok to test

@jan-cerny
Copy link
Collaborator

@openshift-ci-robot

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels May 12, 2020
@jan-cerny jan-cerny self-assigned this May 12, 2020
@jan-cerny jan-cerny added this to the 0.1.51 milestone May 12, 2020
@jan-cerny
Copy link
Collaborator

@willumpie Great! Thanks.

@jan-cerny jan-cerny merged commit be95698 into ComplianceAsCode:master May 12, 2020
@willumpie willumpie deleted the cis_partitions_rules branch May 13, 2020 12:55
@willumpie
Copy link
Contributor Author

jan-cerny: Thanks for merging.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny left review comments

Assignees

@jan-cerny jan-cerny

Labels
ok-to-test Used by openshift-ci bot.
Projects
None yet
Milestone
0.1.51
Development

Successfully merging this pull request may close these issues.
6 participants
@willumpie @openscap-ci @pep8speaks @openshift-ci-robot @redhatrises @jan-cerny