Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev_shm rules to rhel7 stig profile #5830

Merged

Conversation

gcampbell12
Copy link
Contributor

@gcampbell12 gcampbell12 commented Jun 9, 2020

Description:

Rationale:

@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@openshift-ci-robot
Copy link
Collaborator

Hi @gcampbell12. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Jun 9, 2020
@redhatrises
Copy link
Contributor

@openscap-ci test this please

@mildas
Copy link
Contributor

mildas commented Jun 9, 2020

Changes identified:
Profile stig on rhel7:
 Rule mount_option_dev_shm_nodev, mount_option_dev_shm_nosuid, mount_option_dev_shm_noexec added to stig profile.

Recommended tests to execute:
 build_product rhel7
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel7-ds.xml stig

@redhatrises redhatrises added the bugfix Fixes to reported bugs. label Jun 9, 2020
@redhatrises redhatrises self-assigned this Jun 9, 2020
@redhatrises redhatrises added this to the 0.1.51 milestone Jun 9, 2020
@redhatrises
Copy link
Contributor

Ack. Thanks for the contribution!

@redhatrises redhatrises merged commit f6a929e into ComplianceAsCode:master Jun 9, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
5 participants